Activity Log Manager

Merge lp://staging/~jbicha/activity-log-manager/rename-standalone-title-too into lp://staging/activity-log-manager

  1. rename-standalone-title-too
  2. Merge into redesign
Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 75
Proposed branch: lp://staging/~jbicha/activity-log-manager/rename-standalone-title-too
Merge into: lp://staging/activity-log-manager
Diff against target: 12 lines (+1/-1)
1 file modified
src/alm.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~jbicha/activity-log-manager/rename-standalone-title-too
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) Needs Information
Review via email: mp+173061@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

to match the title in activity-log-manager.desktop.in

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I would say that it is better to rename the title in activity-log-manager.desktop.in to "Privacy".

The name "Activity Log Manager" should just be a technical name and not exposed to users. It doesn't convey much information to the users.

review: Needs Fixing
Revision history for this message
Jeremy Bícha (jbicha) wrote :

The standalone panel shouldn't be named "Privacy" because that name is already used by GNOME Settings 3.8.

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

In this case can there be some other name possible instead of "Activity Log Manager" which doesn't convey any meaning.

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches