Activity Log Manager

Merge lp://staging/~jbicha/activity-log-manager/add-search-tab into lp://staging/activity-log-manager

  1. add-search-tab
  2. Merge into redesign
Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 73
Proposed branch: lp://staging/~jbicha/activity-log-manager/add-search-tab
Merge into: lp://staging/activity-log-manager
Diff against target: 161 lines (+107/-0)
5 files modified
po/POTFILES.in (+1/-0)
po/POTFILES.skip (+1/-0)
src/Makefile.am (+1/-0)
src/activity-log-manager.vala (+5/-0)
src/searchresults-widget.vala (+99/-0)
To merge this branch: bzr merge lp://staging/~jbicha/activity-log-manager/add-search-tab
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) Approve
Review via email: mp+173393@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I was thinking if instead of having a separate Search Results tab, why not have it under Security. That tab can contain Scopes enable/disable too.

review: Needs Information
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Clarified. Search Results will contain Online Search enable/disable as well as scopes enable/disable

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches