Activity Log Manager

Merge lp://staging/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp://staging/activity-log-manager

add-apps-drop-spreadsheets-presentations
Merge into redesign

Proposed by Jeremy Bícha on 2013-07-11

Status:

Merged

Merged at revision:

Proposed branch:

lp://staging/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations

Merge into:

lp://staging/activity-log-manager

Diff against target:

18 lines (+2/-3)

1 file modified

src/unified-privacy.vala (+2/-3)

To merge this branch:

bzr merge lp://staging/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Manish Sinha (मनीष सिन्हा)		2013-07-11	Approve on 2013-07-21
Review via email: mp+174096@code.staging.launchpad.net

Description of the change

...and changes the capitalization of "Chat Logs" to "Chat logs" which I think fits better in the style Unity is aiming towards in the dash and elsewhere.

Revision history for this message

Manish Sinha (मनीष सिन्हा) (manishsinha) wrote on 2013-07-20:

I am not sure if dropping Presentations and Spreadsheets makes sense because Datahub's recent-manager-provider.vala does take care of openoffice stuff. Check lines 113 and it is able to deduce the proper Interpretation from the mimetype (line 148)

review: Needs Information

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2013-07-20:

Yes, Zeitgeist can handle Spreadsheets separately than Presentations but I can't think of a good reason why a typical user wouldn't just want a single toggle for all document types.

I used zg's data/ontology/nfo.trig to see that Spreadsheets and Presentations are subclasses of Documents anyway (as are several other document types that we don't have toggles for).

Revision history for this message

Manish Sinha (मनीष सिन्हा) (manishsinha) on 2013-07-21:

review: Approve