Merge lp://staging/~jbaker/storm/oracle_support into lp://staging/storm

This should be ready for merge. I've commented out the disconnection tests for now. Some parts of this are still somewhat ugly, but it's a good starting point.

[1]

I've managed to get Oracle XE installed, but I'm having trouble
getting cx_Oracle in place, so I can't run the test suite yet. I'm
going to keep at it, but if you have any hints on how to get
cx_Oracle in place (on a 64-bit machine) I'd appreciate some help.
Ideally, packages for Ubuntu would be nice.

[2]

I've pushed a branch that adds some details about getting Oracle XE
installed on a 64-bit machine to the README file and makes some
cosmetic changes to make the code match the Storm coding style more
closely. Please merge:

lp:~jkakar/storm/oracle-support-tweaks

[3]

Why isn't the builtin reserved words functionality being used?

I've made a broad pass over the changeset and it looks really good.
I'd like to get the test suite running before I do a more detailed
pass.

> [1]
>
> I've managed to get Oracle XE installed, but I'm having trouble
> getting cx_Oracle in place, so I can't run the test suite yet. I'm
> going to keep at it, but if you have any hints on how to get
> cx_Oracle in place (on a 64-bit machine) I'd appreciate some help.
> Ideally, packages for Ubuntu would be nice.

I found this blog post to be a good help: http://catherinedevlin.blogspot.com/2007/10/cxoracle-and-oracle-xe-on-ubuntu.html ... Although note that they're a little bit outdated. I don't believe it's necessary to install the XE patch.

If you can give me a specific error message, I might be able to help out.

> [2]
>
> I've pushed a branch that adds some details about getting Oracle XE
> installed on a 64-bit machine to the README file and makes some
> cosmetic changes to make the code match the Storm coding style more
> closely. Please merge:
>
> lp:~jkakar/storm/oracle-support-tweaks

I'll look at them. Thanks!

> [3]
>
> Why isn't the builtin reserved words functionality being used?

I don't recall the *exact* reason why I did that, but there was some issue with the reserved word keylist considering words to be reserved that weren't. Perhaps a better solution would be to update the reserved word list. It's a bit dated (SQL 1992).

> lp:~jkakar/storm/oracle-support-tweaks

Erm.... This branch doesn't seem to exist. Unless of course I'm doing something wrong (which is possible).

Oops, the branch was private by mistake. It should be visible now.

Where do we stand on this? I've just merged in the latest revisions from trunk and also added a bugfix that makes the disconnection tests now pass.

I had spent some time looking at this a while ago. I got as far as
getting Oracle installed (which was hard on 64-bit) and then stopped
when I had to figure out how to compile cxOracle DB-API drivers. I
looked over the code, and it looks good, but want to actually be
able to run the test suite.

I've since installed a new disk in my machine, so I'll need to setup
Oracle et al. again to continue. I've been thinking that we really
need a buildbot, since getting Oracle in place is rather awkward and
most Storm developers probably won't want to do it.

I haven't managed to get Oracle installed. I'm going to abstain
from reviewing this for now.