Merge lp://staging/~jaywink/ubuntu-accomplishments-viewer/viewer-fix-for-1026406 into lp://staging/ubuntu-accomplishments-viewer
Proposed by
Jason Robinson
| Status: | Merged |
|---|---|
| Merged at revision: | 151 |
| Proposed branch: | lp://staging/~jaywink/ubuntu-accomplishments-viewer/viewer-fix-for-1026406 |
| Merge into: | lp://staging/ubuntu-accomplishments-viewer |
| Diff against target: |
156 lines (+59/-49) 1 file modified
accomplishments_viewer/AccomplishmentsViewerWindow.py (+59/-49) |
| To merge this branch: | bzr merge lp://staging/~jaywink/ubuntu-accomplishments-viewer/viewer-fix-for-1026406 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jono Bacon | Pending | ||
|
Review via email:
|
|||
Description of the change
Fix for bug 1026406 - try/except to catch import error of GwibberGtk, disable gwibber sharing if not found
Is this enough for now or should we add some kind of notice to the user that sharing is not possible due to missing libraries?
To post a comment you must log in.
Revision history for this message
| Jono Bacon (jonobacon) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for your contribution, Jason, this looks great! I don't think we need to notify the user of missing packages, and I think your fix solves this issue perfectly.
I just merged it in - thanks for your contribution, and welcome to the development team!