Merge lp://staging/~javier.collado/utah/bug1071020 into lp://staging/utah

Proposed by Javier Collado
Status: Merged
Approved by: Javier Collado
Approved revision: 828
Merged at revision: 827
Proposed branch: lp://staging/~javier.collado/utah/bug1071020
Merge into: lp://staging/utah
Diff against target: 33 lines (+12/-0)
2 files modified
debian/changelog (+2/-0)
utah/client/common.py (+10/-0)
To merge this branch: bzr merge lp://staging/~javier.collado/utah/bug1071020
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+151527@code.staging.launchpad.net

Description of the change

This branch creates a fake command result when the run_as user is not found in
the password database with an error that is friendlier than the error that the
user would get if the command were really executed.

I don't like much creating fake results to convey error messages, but I haven't
found any better way to do this. Maybe we could create a different result
dictionary for those commands that haven't been executed, but I don't really
thing that is worth the effort for now. Please let me now your thoughts on this.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

+1

Revision history for this message
Max Brustkern (nuclearbob) wrote :

This looks good to me. At some point, I think it would be nice if we could find a good way to support a generic 'unprivileged' user that would use the default user on the system, but maybe the real answer is that provisioning should always install the system with the same unprivileged user...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches