Merge lp://staging/~javier.collado/ubuntu-test-runlists/jenkins-smoketest-setup-publish-flag into lp://staging/~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup
Proposed by
Javier Collado
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Javier Collado | ||||
Approved revision: | 49 | ||||
Merged at revision: | 47 | ||||
Proposed branch: | lp://staging/~javier.collado/ubuntu-test-runlists/jenkins-smoketest-setup-publish-flag | ||||
Merge into: | lp://staging/~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup | ||||
Diff against target: |
52 lines (+10/-2) 2 files modified
setup-jobs.py (+8/-2) templates/base.xml.jinja (+2/-0) |
||||
To merge this branch: | bzr merge lp://staging/~javier.collado/ubuntu-test-runlists/jenkins-smoketest-setup-publish-flag | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Javier Collado (community) | Approve | ||
Max Brustkern (community) | Approve | ||
Review via email: mp+155719@code.staging.launchpad.net |
Description of the change
This branch adds a command line flag (publish) that is used to set when to
publish job results.
The default value is false, so the user has to explicitly pass it to set job
configuration to publish. This way a user can verify that the job works fine
and then run the script again with `--publish` to publish future results.
To post a comment you must log in.
Seems completely straightforward to me. Have you tested it? Do we have a good way to test this on a dummy instance or something? I usually just edit the code to dump the xml, but that's probably not the best way to do it.