Merge lp://staging/~javier.collado/autopilot/bug1285575 into lp://staging/autopilot

Proposed by Javier Collado
Status: Needs review
Proposed branch: lp://staging/~javier.collado/autopilot/bug1285575
Merge into: lp://staging/autopilot
Diff against target: 263 lines (+195/-1)
2 files modified
autopilot/introspection/__init__.py (+76/-1)
autopilot/tests/unit/test_introspection_features.py (+119/-0)
To merge this branch: bzr merge lp://staging/~javier.collado/autopilot/bug1285575
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Autopilot Hackers Pending
Review via email: mp+208638@code.staging.launchpad.net

Commit message

Get proxy object faster if process information is given

Process name and command line can be passed to filter processes based on the information from /proc/<pid>/ to get a proxy object faster (no need to query multiple connections through dbus and wait for long time because of timeouts)

Description of the change

This change adds the process_name and process_cmdline options to
autopilot.introspection.get_proxy_object_for_existing_process.

This can be used to get a proxy object faster than with only the
application_name since there's no need to query each dbus connection one by one
to find the one for the application being searched.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
447. By Javier Collado

Fixed test_makes_child_calls

autopilot.tests.unit.test_introspection_features.ProxyObjectGenerationTests.test_makes_child_calls

448. By Javier Collado

Fixed test_raises_ProcessSearchError

autopilot.tests.unit.test_introspection_features.ProxyObjectGenerationTests.test_raises_ProcessSearchError

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
449. By Javier Collado

Added a few test cases for _check_proc_fs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

449. By Javier Collado

Added a few test cases for _check_proc_fs

448. By Javier Collado

Fixed test_raises_ProcessSearchError

autopilot.tests.unit.test_introspection_features.ProxyObjectGenerationTests.test_raises_ProcessSearchError

447. By Javier Collado

Fixed test_makes_child_calls

autopilot.tests.unit.test_introspection_features.ProxyObjectGenerationTests.test_makes_child_calls

446. By Javier Collado

Added _check_proc_fs function

This function helps to search a process for a given process name and/or process
command line. The name and command line are extracted from /proc/<pid>/stat and
/proc/<pid>/cmdline by the psutil library.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches