Merge lp://staging/~jamestait/rnr-server/sca-conn-check-301 into lp://staging/rnr-server
Proposed by
James Tait
Status: | Merged |
---|---|
Approved by: | Wes Mason |
Approved revision: | 323 |
Merged at revision: | 322 |
Proposed branch: | lp://staging/~jamestait/rnr-server/sca-conn-check-301 |
Merge into: | lp://staging/rnr-server |
Diff against target: |
50 lines (+9/-2) 1 file modified
scripts/settings-to-conncheck.py (+9/-2) |
To merge this branch: | bzr merge lp://staging/~jamestait/rnr-server/sca-conn-check-301 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Wes Mason (community) | Approve | ||
Daniel Manrique (community) | Approve | ||
Review via email:
|
Commit message
Update the conn-check settings generator to expect an HTTP 301 from SCA rather than a 302.
Description of the change
Update the conn-check settings generator to expect an HTTP 301 from SCA rather than a 302.
To post a comment you must log in.
You're changing a 302 (found, nothing else changes) to a 301 (redirect). I guess the question is, which URL will conn-check look for? if it's happy with the wanted URL giving a 301, regardless of the Location: header and won't do anything crazy like following the redirect until it gets a more definitive code, then this is fine. If, OTOH, conn-check follows the redirect, then I suspect the URL would need updating to the target one.
So this looks OK in principle, just need to clarify this bit.