Ubuntu
pbuilder package

Merge lp://staging/~jamesodhunt/ubuntu/raring/pbuilder/dep8-procenv into lp://staging/ubuntu/raring/pbuilder

  1. Raring (13.04)
  2. dep8-procenv
  3. Merge into raring
Proposed by James Hunt
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp://staging/~jamesodhunt/ubuntu/raring/pbuilder/dep8-procenv
Merge into: lp://staging/ubuntu/raring/pbuilder
Diff against target: 152 lines (+123/-0)
4 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
debian/tests/build_procenv (+113/-0)
debian/tests/control (+3/-0)
To merge this branch: bzr merge lp://staging/~jamesodhunt/ubuntu/raring/pbuilder/dep8-procenv
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Jean-Baptiste Lallement (community) Approve
Review via email: mp+159690@code.staging.launchpad.net

Description of the change

Added a DEP-8 test to exercise pbuilder by performing the following:

- creates an pbuilder chroot for the current release
- builds the 'procenv' package (*)
- installs the resulting .deb
- runs the command provided by the .deb

(*) - procenv was chosen to allow both the pbuilder and AutoPkgTest environments to be seen by looking at the logfile for this test.

Analogous to lp:~jamesodhunt/ubuntu/raring/sbuild/dep8-procenv.

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for this patch!

It worked fine in my test environment. Approved.

review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I'm not sure if it's a good idea to require network connection for autopkgtests (for apt-get source), but if our server is connected to the web, I have no objections.

Also, please forward this to Debian (if you did not already).

Revision history for this message
James Hunt (jamesodhunt) wrote :

Submitted to Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=705917

lp://staging/~jamesodhunt/ubuntu/raring/pbuilder/dep8-procenv updated
54. By James Hunt

* debian/tests/build_procenv: Aligned with sbuild DEP-8 script:
  - Use appropriate archive based on distribution.
  - Build package for specified distribution (stable for debian to
    ensure chroot is creatable).
  - Download package source for specified release.
  - Only install build .deb if host environment matches the release the
    package was built for.
  - Perform basic checks on built .dep in case it is not possible to
    install it.
* debian/tests/control: Add distro-info and lsb-release dependencies.

Revision history for this message
Martin Pitt (pitti) wrote :

Tested on current saucy with "run-adt-test -sS lp:~jamesodhunt/ubuntu/raring/pbuilder/dep8-procenv pbuilder", success. Thanks!

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

I merge this into saucy, thus closing manually.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: