lp://staging/~jamesodhunt/libnih/bug-776532

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/~upstart-devel/libnih/nih

Steve Langasek: Disapprove on 2013-03-13

Diff: 167 lines (+102/-1)

3 files modified

ChangeLog (+10/-0)
nih/file.c (+32/-1)
nih/tests/test_watch.c (+60/-0)

api

Approved for merging into lp://staging/libnih

Steve Langasek (community): Disapprove on 2013-03-13

Scott James Remnant: Approve on 2012-04-27

Diff: 167 lines (+102/-1)

3 files modified

ChangeLog (+10/-0)
nih/file.c (+32/-1)
nih/tests/test_watch.c (+60/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #776532: nih_dir_walk_scan passes incorrect value to file filter

Undecided

Triaged

Link a bug report

Related blueprints

1055. By James Hunt on 2012-04-27

* nih/file.c (nih_dir_walk_filter): New NihFileFilter function passed to
nih_dir_walk_scan() to ensure the nih_watch_new() filter function is
passed the NihWatch data rather than the data passed to the
nih_dir_walk() NihFileVisitor function (LP: #776532).

* nih/tests/test_watch.c (test_new): New test "with filter and data"
to ensure filter is passed correct value.

1054. By Scott James Remnant (Canonical) on 2011-09-01

* nih-dbus-tool/tests/test_com.netsplit.Nih.Test_object.c
(test_unix_fd_to_str): Sanity check value before invoking strchr in
case it returns address of null (which would give a misleading test
pass).
* nih-dbus-tool/tests/test_com.netsplit.Nih.Test_proxy.c
(test_unix_fd_to_str, test_unix_fd_to_str_sync): Sanity check value
before invoking strchr in case it returns address of null (which would
give a misleading test pass).
* nih/config.c (): nih_config_block_end: Add check to ensure strchr()
doesn't return address of null since this would result in a misleading
return value of TRUE.

1053. By Scott James Remnant (Canonical) on 2011-08-31

* nih/string.c (nih_str_split): Fixes to avoid over-running
input string and also returning an empty string array entry
when repeat is true (LP: #834813).
* nih/tests/test_string.c (test_str_split): Added a lot of new
tests for nih_str_split().

1052. By Scott James Remnant (Canonical) on 2011-08-26

* nih/io.c (nih_io_select_fds): Ensure number of fds being managed
is within limits.

1051. By Scott James Remnant (Canonical) on 2011-08-26

Bump copyright dates to 2011

1050. By Scott James Remnant (Canonical) on 2011-08-26

* nih/config.c, nih/error.h, nih/io.c, nih/test_files.h: Correct
typos in comments.

1049. By Scott James Remnant (Canonical) on 2011-06-20

* nih/watch.c (nih_watch_handle): Handle non-directory watches;
previously a file watch resulted in an invalid file path ending in
a single slash (LP:#777097).
* nih/tests/test_watch.c: Added explicit test for watch on a file.

1048. By Scott James Remnant (Canonical) on 2011-01-14

Typo fixes from James

1047. By Scott James Remnant (Canonical) on 2010-12-23

* configure.ac: Bump version to 1.0.4
* NEWS: Begin new release

1046. By Scott James Remnant (Canonical) on 2010-12-23

* NEWS: Release 1.0.3