Merge lp://staging/~jamesh/wsgi-oops/optional-404-oops into lp://staging/wsgi-oops
Proposed by
James Henstridge
| Status: | Merged |
|---|---|
| Approved by: | Tim Cole |
| Approved revision: | 55 |
| Merged at revision: | 55 |
| Proposed branch: | lp://staging/~jamesh/wsgi-oops/optional-404-oops |
| Merge into: | lp://staging/wsgi-oops |
| Diff against target: |
86 lines (+39/-5) 3 files modified
canonical/oops/tests/test_wsgi.py (+30/-2) canonical/oops/tests/testcase.py (+4/-1) canonical/oops/wsgi.py (+5/-2) |
| To merge this branch: | bzr merge lp://staging/~jamesh/wsgi-oops/optional-404-oops |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Cole (community) | Approve | ||
| Martin Albisetti (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make reporting of 404 errors optional, via an optional oops_on_404 parameter for OopsWare.
Description of the change
Currently OopsWare is hard coded to generate OOPS reports for any request that has a Referer and results in a 404 response.
This is useful for sites with fairly static URLs, since these broken links could indicate problems with a site update. However if users of the site can create and destroy URLs at will. then broken links will be more common and less likely to indicate site bugs.
This branch makes the behaviour optional, so the latter sites can remove the source of noise. The default behaviour is not changed.
To post a comment you must log in.
Revision history for this message
| Martin Albisetti (beuno) | # |
review:
Approve
Revision history for this message
| Tim Cole (tcole) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
