unity-lens-applications

Merge lp://staging/~jamesh/unity-lens-applications/scope-previews into lp://staging/~unity-team/unity-lens-applications/libunity7-compatible

scope-previews
Merge into libunity7-compatible

Proposed by James Henstridge on 2013-04-30

Status:

Merged

Approved by:

Michal Hruby on 2013-05-01

Approved revision:

348

Merged at revision:

344

Proposed branch:

lp://staging/~jamesh/unity-lens-applications/scope-previews

Merge into:

lp://staging/~unity-team/unity-lens-applications/libunity7-compatible

Diff against target:

615 lines (+313/-256)

1 file modified

src/daemon.vala (+313/-256)

To merge this branch:

bzr merge lp://staging/~jamesh/unity-lens-applications/scope-previews

Related bugs:

Bug #1174453: Previews for scopes should use a screenshot of web page	High	Fix Committed
Bug #1174910: It should not be possible to disable the App Scope from within the App Lens preview.	Critical	Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-05-01
Michal Hruby (community)		2013-04-30	Approve on 2013-05-01
Review via email: mp+161534@code.staging.launchpad.net

Commit message

Add screenshots to local scope previews with information obtained from the software center, escape markup characters in descriptions and don't allow the user to disable the applications scope.

Description of the change

When creating previews for local scopes, look up the package name in the software center index (requires scopes to be included in the app-install data) and then query the data provider for screenshots to include in the preview. This

As the preview() method was getting quite long, I also took the opportunity to split it into the app preview and scope preview cases into their own methods.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-30:

PASSED: Continuous integration, rev:343
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-applications-libunity7-compatible-ci/11/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-applications-libunity7-compatible-raring-amd64-ci/11

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-applications-libunity7-compatible-ci/11/rebuild

review: Approve (continuous-integration)

lp://staging/~jamesh/unity-lens-applications/scope-previews updated on 2013-05-01

344. By James Henstridge on 2013-05-01: Escape special characters in the scope description when producing
previews.
345. By James Henstridge on 2013-05-01: Don't include scope description in comment field of search results.
346. By James Henstridge on 2013-05-01: Don't show the enable/disable buttons in the preview of the applications
scope.