Merge lp://staging/~jamesh/unity-lens-applications/scope-previews into lp://staging/~unity-team/unity-lens-applications/libunity7-compatible

Proposed by James Henstridge
Status: Merged
Approved by: Michal Hruby
Approved revision: 348
Merged at revision: 344
Proposed branch: lp://staging/~jamesh/unity-lens-applications/scope-previews
Merge into: lp://staging/~unity-team/unity-lens-applications/libunity7-compatible
Diff against target: 615 lines (+313/-256)
1 file modified
src/daemon.vala (+313/-256)
To merge this branch: bzr merge lp://staging/~jamesh/unity-lens-applications/scope-previews
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+161534@code.staging.launchpad.net

Commit message

Add screenshots to local scope previews with information obtained from the software center, escape markup characters in descriptions and don't allow the user to disable the applications scope.

Description of the change

When creating previews for local scopes, look up the package name in the software center index (requires scopes to be included in the app-install data) and then query the data provider for screenshots to include in the preview. This

As the preview() method was getting quite long, I also took the opportunity to split it into the app preview and scope preview cases into their own methods.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
344. By James Henstridge

Escape special characters in the scope description when producing
previews.

345. By James Henstridge

Don't include scope description in comment field of search results.

346. By James Henstridge

Don't show the enable/disable buttons in the preview of the applications
scope.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
347. By James Henstridge

Merge from libunity7-compatible, fixing conflict

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
348. By James Henstridge

Also remove the disable action for the home scope.

Revision history for this message
Michal Hruby (mhr3) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: