lp://staging/~jamesh/thumbnailer/aa-access-fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/thumbnailer/devel at revision 219

PS Jenkins bot (community): Approve (continuous-integration) on 2015-06-18

Michi Henning (community): Approve on 2015-06-18

Diff: 315 lines (+50/-44)

4 files modified

include/internal/thumbnailer.h (+3/-2)
src/service/handler.cpp (+10/-1)
src/thumbnailer.cpp (+19/-18)
tests/thumbnailer/thumbnailer_test.cpp (+18/-23)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1381713: Support policy query interface for file

Undecided

Fix Released

Link a bug report

Related blueprints

220. By James Henstridge on 2015-06-18

Fix stale comment, as per Michi's review.

219. By James Henstridge on 2015-06-18

Rename ThumbnailRequest::set_client_credentials to
check_client_credentials, and move the AppArmor check for
LocalThumbnailRequest to that method. Previously we would provide
cached thumbnails to clients without the permission check.

218. By James Henstridge on 2015-06-17

Remove the filename_fd argument to the GetThumbnail() D-Bus method, instead using aa_query_label() to check whether the caller has access to the relevant file. Fixes: https://bugs.launchpad.net/bugs/1381713.

Approved by PS Jenkins bot, Michi Henning.

217. By Michi Henning on 2015-06-15

Made download/extract timeout configurable.

Approved by James Henstridge, PS Jenkins bot.

216. By Michi Henning on 2015-06-15

More detailed trace. It now splits out time spent waiting in queue and actual extraction time, so we can see whether a request was slow because it was delayed in the queue, or because the extraction itself was slow.

Approved by James Henstridge, PS Jenkins bot.

215. By James Henstridge on 2015-06-15

If the subprocess is still running in the ImageExtractor destructor, try to kill it again, and log if waitForFinished() fails.

Approved by PS Jenkins bot, Michi Henning.

214. By James Henstridge on 2015-06-15

Track the credentials (user ID, AppArmor label) of clients connecting to the D-Bus service. This is not yet used to make security decisions.

Approved by Michi Henning, PS Jenkins bot.

213. By Michi Henning on 2015-06-11

Minor fixes to speed test: adjusted some types to prevent overflow when benchmarking very large caches and fixed two insignificant off-by-one errors. Changed prerequisite branch; now calling compact() explicitly in speed test.

Approved by PS Jenkins bot, Michi Henning, James Henstridge.

212. By Michi Henning on 2015-06-11

Cache no longer implicitly compacts the DB on shutdown. Instead, it now provides an explicit compact() method. The DBus service now shuts down the thumbnailer before tearing down the DBus connection, so it is guaranteed that the DB locks are released before DBus can start another service instance.

Approved by Michi Henning, PS Jenkins bot, James Henstridge.

211. By Michi Henning on 2015-06-11

Factored out dbus name and dbus paths into separate header so they aren't hard-wired repeatedly all over the place. Also made a bunch of style fixes and removed a bunch of redundant header files.

Approved by Michi Henning, PS Jenkins bot, James Henstridge.