lp://staging/~jamesh/thumbnailer/aa-access-fix

Created by James Henstridge and last modified
Get this branch:
bzr branch lp://staging/~jamesh/thumbnailer/aa-access-fix
Only James Henstridge can upload to this branch. If you are James Henstridge please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
James Henstridge
Project:
Thumbnailer
Status:
Merged

Recent revisions

220. By James Henstridge

Fix stale comment, as per Michi's review.

219. By James Henstridge

Rename ThumbnailRequest::set_client_credentials to
check_client_credentials, and move the AppArmor check for
LocalThumbnailRequest to that method. Previously we would provide
cached thumbnails to clients without the permission check.

218. By James Henstridge

Remove the filename_fd argument to the GetThumbnail() D-Bus method, instead using aa_query_label() to check whether the caller has access to the relevant file. Fixes: https://bugs.launchpad.net/bugs/1381713.

Approved by PS Jenkins bot, Michi Henning.

217. By Michi Henning

Made download/extract timeout configurable.

Approved by James Henstridge, PS Jenkins bot.

216. By Michi Henning

More detailed trace. It now splits out time spent waiting in queue and actual extraction time, so we can see whether a request was slow because it was delayed in the queue, or because the extraction itself was slow.

Approved by James Henstridge, PS Jenkins bot.

215. By James Henstridge

If the subprocess is still running in the ImageExtractor destructor, try to kill it again, and log if waitForFinished() fails.

Approved by PS Jenkins bot, Michi Henning.

214. By James Henstridge

Track the credentials (user ID, AppArmor label) of clients connecting to the D-Bus service. This is not yet used to make security decisions.

Approved by Michi Henning, PS Jenkins bot.

213. By Michi Henning

Minor fixes to speed test: adjusted some types to prevent overflow when benchmarking very large caches and fixed two insignificant off-by-one errors. Changed prerequisite branch; now calling compact() explicitly in speed test.

Approved by PS Jenkins bot, Michi Henning, James Henstridge.

212. By Michi Henning

Cache no longer implicitly compacts the DB on shutdown. Instead, it now provides an explicit compact() method. The DBus service now shuts down the thumbnailer before tearing down the DBus connection, so it is guaranteed that the DB locks are released before DBus can start another service instance.

Approved by Michi Henning, PS Jenkins bot, James Henstridge.

211. By Michi Henning

Factored out dbus name and dbus paths into separate header so they aren't hard-wired repeatedly all over the place. Also made a bunch of style fixes and removed a bunch of redundant header files.

Approved by Michi Henning, PS Jenkins bot, James Henstridge.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp://staging/thumbnailer
This branch contains Public information 
Everyone can see this information.

Subscribers