Ubuntu Distributed Development

Merge lp://staging/~james-w/udd/drop_email_failures into lp://staging/udd

  1. drop_email_failures
  2. Merge into import-scripts
Proposed by James Westby
Status: Rejected
Rejected by: Vincent Ladeuil
Proposed branch: lp://staging/~james-w/udd/drop_email_failures
Merge into: lp://staging/udd
Prerequisite: lp://staging/~james-w/udd/drop-cricket
Diff against target: 97 lines (+0/-74)
4 files modified
bin/email-failures (+0/-7)
importer.crontab (+0/-1)
udd/scripts/email_failures.py (+0/-55)
udd/tests/test_email_failures.py (+0/-11)
To merge this branch: bzr merge lp://staging/~james-w/udd/drop_email_failures
Reviewer Review Type Date Requested Status
Vincent Ladeuil Disapprove
Martin Pool Approve
Review via email: mp+85722@code.staging.launchpad.net

Description of the change

Hi,

The email-failures script output isn't going to anywhere that is being
read that I am aware of, so we should drop it.

Thanks,

James

To post a comment you must log in.
lp://staging/~james-w/udd/drop_email_failures updated
559. By James Westby

Merged drop-cricket into drop_email_failures.

Revision history for this message
Martin Pool (mbp) wrote :

I do get and scan the email, but I won't miss them if they stop.

  vote approve

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

I don't get the email but would love to. Never found where I should add my email for that though.

Now, if I understand it correctly, this will send a single email for all failure where I'd prefer a single mail by failure.

My use case is that I sometimes postpone requeuing a failed import that looks spurious until I can capture the traceback somewhere. Receiving an email for such failures and being able to 'just hit delete' for the uninteresting ones would be ideal.

Revision history for this message
Martin Pool (mbp) wrote :

On 17 December 2011 00:43, Vincent Ladeuil <email address hidden> wrote:
> I don't get the email but would love to. Never found where I should add my email for that though.
>
> Now, if I understand it correctly, this will send a single email for all failure where I'd prefer a single mail by failure.
>
> My use case is that I sometimes postpone requeuing a failed import that looks spurious until I can capture the traceback somewhere. Receiving an email for such failures and being able to 'just hit delete' for the uninteresting ones would be ideal.

I think this is controlled by ~pkg_import/.forward. I've added you.
If it's useful and James doesn't find it too bad to have it in the
tree, let's leave it.

--
Martin

Revision history for this message
James Westby (james-w) wrote :

On Mon, 19 Dec 2011 18:03:24 +1100, Martin Pool <email address hidden> wrote:
> I think this is controlled by ~pkg_import/.forward. I've added you.
> If it's useful and James doesn't find it too bad to have it in the
> tree, let's leave it.

Yeah, if it's being used it won't be much work to keep it around.

Thanks,

James

Revision history for this message
Vincent Ladeuil (vila) wrote :

This has been used and useful so rejecting the proposal.

review: Disapprove

Unmerged revisions

559. By James Westby

Merged drop-cricket into drop_email_failures.

558. By James Westby

Merge trunk.

557. By James Westby

Drop it from the crontab too.

556. By James Westby

Drop email_failures as it isn't used.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches