Testrepository

Merge lp://staging/~james-w/testrepository/run-specify-ids into lp://staging/~testrepository/testrepository/trunk

  1. run-specify-ids
  2. Merge into trunk
Proposed by James Westby
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp://staging/~james-w/testrepository/run-specify-ids
Merge into: lp://staging/~testrepository/testrepository/trunk
Diff against target: 58 lines (+24/-1)
3 files modified
NEWS (+3/-0)
testrepository/commands/run.py (+6/-1)
testrepository/tests/commands/test_run.py (+15/-0)
To merge this branch: bzr merge lp://staging/~james-w/testrepository/run-specify-ids
Reviewer Review Type Date Requested Status
testrepository committers Pending
Review via email: mp+28180@code.staging.launchpad.net

Commit message

testr run now supports limiting the tests run when using $IDLIST.

Description of the change

Hi,

I found that

  testr run foo

would run all the tests plus foo, whereas I wanted to run a subset of
tests.

This is specific to $IDLIST, there is a test for $IDOPTION, so I added
a similar one for $IDLIST, and then fixed the code.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

So James and I spoke about this back when he did it; its in an awkward part of the code base; there is a bug open about the larger rework needed. I'm concerned that landing this takes the code in the wrong direction; I need to dig in and think clearly about it again. Sorry for the enormous delays around this.

Revision history for this message
James Westby (james-w) wrote :

Rejecting as it's not going anywhere.

Thanks,

James

Revision history for this message
Robert Collins (lifeless) wrote :

I've landed code that provides regex based filtering and abstracts away the underlying runner from needing anything more than load-list and list-tests support; so this is strictly more powerful. Marking rejected to close it off.

Unmerged revisions

93. By James Westby

Add a NEWS entry.

92. By James Westby

Run only the tests specified on the command line with $IDLIST.

If the user specifies some test arguments then run with only those
arguments. Before this didn't work with $IDLIST, which would run
the default set of tests, plus those specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches