Merge lp://staging/~james-w/tarmac/utf8 into lp://staging/tarmac
Status: | Rejected |
---|---|
Rejected by: | dobey |
Proposed branch: | lp://staging/~james-w/tarmac/utf8 |
Merge into: | lp://staging/tarmac |
Prerequisite: | lp://staging/~james-w/tarmac/setsid |
Diff against target: |
11 lines (+1/-1) 1 file modified
tarmac/plugins/command.py (+1/-1) |
To merge this branch: | bzr merge lp://staging/~james-w/tarmac/utf8 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey | Disapprove | ||
Paul Hummer | Approve | ||
Review via email: mp+144807@code.staging.launchpad.net |
Commit message
Force output to utf-8
Description of the change
This is a bugfix we used in CA when we were seeing failures because of some
test output causing decode errors.
Those errors probably indicate an environment configuration issue, but this
change gives the user some indication of what was going on, rather than just
a UnicodeDecodeError traceback.
(from the u1 fork)
Unmerged revisions
- 421. By James Westby
-
Merged setsid into utf8.
- 420. By James Westby
-
Drop unneeded change.
- 419. By James Westby
-
Merged setsid into utf8.
- 418. By James Westby
-
Merged branch-
tree-properties into utf8. - 417. By James Westby
-
Merge trunk.
- 416. By James Westby
-
Merge trunk.
- 415. By James Westby
-
Decode stderr/stdout from the command, ignoring errors.
We were seeing UnicodeDecodeErrors in Jenkins on occaision, so
we changed the code to be more robust, and to discard anything
that couldn't be decoded from utf-8. - 414. By Sidnei da Silva
-
- Disable lightweight checkouts
- 413. By Sidnei da Silva
-
- Oops, target can be None here.
- 412. By Sidnei da Silva
-
- Die locks die
This was also proposed in https:/ /code.launchpad .net/~jameinel/ tarmac/ non_ascii- 750930/ +merge/ 73831 (with tests)