Tarmac

Merge lp://staging/~james-w/tarmac/setsid into lp://staging/tarmac

  1. setsid
  2. Merge into main
Proposed by James Westby
Status: Rejected
Rejected by: dobey
Proposed branch: lp://staging/~james-w/tarmac/setsid
Merge into: lp://staging/tarmac
Prerequisite: lp://staging/~james-w/tarmac/branch-tree-properties
Diff against target: 21 lines (+3/-2)
1 file modified
tarmac/plugins/command.py (+3/-2)
To merge this branch: bzr merge lp://staging/~james-w/tarmac/setsid
Reviewer Review Type Date Requested Status
dobey Disapprove
Paul Hummer Approve
Review via email: mp+144806@code.staging.launchpad.net

Commit message

Call os.setsid to make subprocess a pg lead, invert broken logic on SIGKILL poll().

Description of the change

Call os.setsid to make subprocess a pg lead, invert broken logic on SIGKILL poll().

(from the u1 fork)

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve
Revision history for this message
Paul Hummer (rockstar) wrote :

The prerequisite lp:~james-w/tarmac/branch-tree-properties has not yet been merged into lp:tarmac.

Revision history for this message
dobey (dobey) wrote :

Please create bugs for the issues, include tests, and split the changes into a branch or two which do not have unnecessary dependencies on other unrelated changes.

review: Disapprove

Unmerged revisions

406. By James Westby

Merged branch-tree-properties into setsid.

405. By James Westby

Call os.setsid in subprocess to make it pg lead. Invert broken logic in kill.

404. By James Westby

Use properties to get the branch and tree, rather than assigning at instaniation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches