Merge lp://staging/~james-w/python-oops-tools/weird-statements into lp://staging/python-oops-tools
Proposed by
James Westby
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 54 |
| Merged at revision: | 54 |
| Proposed branch: | lp://staging/~james-w/python-oops-tools/weird-statements |
| Merge into: | lp://staging/python-oops-tools |
| Diff against target: |
53 lines (+32/-0) 2 files modified
src/oopstools/oops/models.py (+4/-0) src/oopstools/oops/test/test_dboopsloader.py (+28/-0) |
| To merge this branch: | bzr merge lp://staging/~james-w/python-oops-tools/weird-statements |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sidnei da Silva (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Ensure that statements are always strings.
Fixes a crash when adding an oops that doesn't have a string for one of
the statements. The data being sent is bad, but a crash means no further
oopses can be processed.
Description of the change
Hi,
This fixes a bug we found in production when a service was generating bad
data for the statement info in the timeline.
This avoids the crash by casting to a string. The data will be nonsense, but
it avoids the crash so that other oopses can be processed.
Thanks,
James
To post a comment you must log in.
Revision history for this message
| Sidnei da Silva (sidnei) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
