pkgme

Merge lp://staging/~james-w/pkgme/informative-skip-message into lp://staging/pkgme

  1. informative-skip-message
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Merged at revision: 58
Proposed branch: lp://staging/~james-w/pkgme/informative-skip-message
Merge into: lp://staging/pkgme
Diff against target: 54 lines (+18/-5)
2 files modified
pkgme/testing.py (+15/-0)
pkgme/tests/test_vala_backend.py (+3/-5)
To merge this branch: bzr merge lp://staging/~james-w/pkgme/informative-skip-message
Reviewer Review Type Date Requested Status
Jonathan Lange Approve
pkgme committers Pending
Review via email: mp+66538@code.staging.launchpad.net

Description of the change

Hi,

This adds a helper for requiring a command for a test method.

It's main use it to give an informative error message with little typing.

It's used to make the one use of require_command with skipTest be more
informative.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

This is good. I would probably have implemented it as, well, anything other than a mixin. e.g. testtools provides @skipIf and @skipUnless decorators. They wouldn't be as informative as this, but you could build something more informative from them.

Huh. I guess this is a useful prompt for testtools to have something to make this easier, much like bzr's feature thing.

Anyway, I'd be happy merging this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: