pkgme

Merge lp://staging/~james-w/pkgme/enable-tests into lp://staging/pkgme

  1. enable-tests
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Approved by: Jonathan Lange
Approved revision: 95
Merged at revision: 92
Proposed branch: lp://staging/~james-w/pkgme/enable-tests
Merge into: lp://staging/pkgme
Diff against target: 162 lines (+51/-19)
8 files modified
pkgme/backends/dummy/package_name (+3/-0)
pkgme/backends/dummy/version (+3/-0)
pkgme/backends/dummy/want (+7/-0)
pkgme/distutils_command/pkgme_info.py (+4/-4)
pkgme/testing.py (+13/-0)
pkgme/tests/test_distutils_command.py (+7/-4)
pkgme/tests/test_script.py (+10/-10)
tarmac_tests.sh (+4/-1)
To merge this branch: bzr merge lp://staging/~james-w/pkgme/enable-tests
Reviewer Review Type Date Requested Status
Jonathan Lange Approve
Review via email: mp+85032@code.staging.launchpad.net

Commit message

Have tarmac run the tests. Skip the debpython tests if it is missing.

Description of the change

Hi,

This is the change to enable the tests for pkgme in tarmac.

I went with disabling the tests using debpython if it's not
present. This isn't ideal, but I figured that testing
99% of the code in tarmac was better than testing 0%.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Looks good to me.

You do have a repeated literal, the path to debpython in your diff is also, sort of, in distutils_command/pkgme_info. Since they both have FIXME comments, it's not such a big deal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: