pkgme

Merge lp://staging/~james-w/pkgme/allowable-backends into lp://staging/pkgme

  1. allowable-backends
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Merged at revision: 84
Proposed branch: lp://staging/~james-w/pkgme/allowable-backends
Merge into: lp://staging/pkgme
Diff against target: 234 lines (+111/-21)
4 files modified
pkgme/__init__.py (+2/-2)
pkgme/backend.py (+31/-10)
pkgme/tests/test_backend.py (+46/-0)
pkgme/tests/test_write_packaging.py (+32/-9)
To merge this branch: bzr merge lp://staging/~james-w/pkgme/allowable-backends
Reviewer Review Type Date Requested Status
Jonathan Lange Needs Fixing
Review via email: mp+80936@code.staging.launchpad.net

Description of the change

Hi,

This allows API users to specify a list of backend names that are
allowed to be loaded.

This will allow us to prevent the python backend from running on the
server.

I went with whitelist rather than blacklist as I thought it would make
deployment easier later.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Hello!

Thanks for this patch. It looks pretty good, except that the exception will probably always have a list of the same backends twice when there are a whitelist of allowed backends. Each backend in the whitelist will be attempted, right? So showing both tried & whitelisted means that there'll be a duplicate list.

Other than that, looks good.

jml

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: