Merge lp://staging/~james-w/pkgme/add-path-to-desktop into lp://staging/pkgme

Proposed by James Westby
Status: Merged
Approved by: Michael Vogt
Approved revision: 119
Merged at revision: 120
Proposed branch: lp://staging/~james-w/pkgme/add-path-to-desktop
Merge into: lp://staging/pkgme
Diff against target: 80 lines (+19/-1)
4 files modified
pkgme/info_elements.py (+7/-1)
pkgme/package_files.py (+2/-0)
pkgme/templates/desktop (+3/-0)
pkgme/tests/test_package_files.py (+7/-0)
To merge this branch: bzr merge lp://staging/~james-w/pkgme/add-path-to-desktop
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+115409@code.staging.launchpad.net

Commit message

Add WorkingDirectory to use as Path in the .desktop file (for bug #1025174)

Description of the change

Hi,

In https://bugs.launchpad.net/pkgme-devportal/+bug/1025174 mvo says that we
should set Path in the .desktop file. This allows the backend to specify
a value if they want.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks fine to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: