Juju Charms Collection
ceph package

Merge lp://staging/~james-page/charms/trusty/ceph/lp1523871-feedback into lp://staging/~openstack-charmers-archive/charms/trusty/ceph/next

  1. Trusty Tahr (14.04)
  2. lp1523871-feedback
  3. Merge into next
Proposed by James Page
Status: Rejected
Rejected by: James Page
Proposed branch: lp://staging/~james-page/charms/trusty/ceph/lp1523871-feedback
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/ceph/next
Diff against target: 187 lines (+62/-12)
3 files modified
config.yaml (+6/-0)
hooks/ceph_hooks.py (+20/-9)
hooks/utils.py (+36/-3)
To merge this branch: bzr merge lp://staging/~james-page/charms/trusty/ceph/lp1523871-feedback
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+286819@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~james-page/charms/trusty/ceph/lp1523871-feedback updated
137. By James Page

Tidy lint

138. By James Page

Final tweak

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1005 ceph-next for james-page mp286819
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1005/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1170 ceph-next for james-page mp286819
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1170/

lp://staging/~james-page/charms/trusty/ceph/lp1523871-feedback updated
139. By James Page

Tweak comment

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #450 ceph-next for james-page mp286819
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15171991/
Build: http://10.245.162.36:8080/job/charm_amulet_test/450/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI, failed on:

2016-02-22 17:19:15 INFO config-changed File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/utils.py", line 103, in get_network_addrs
2016-02-22 17:19:15 INFO config-changed networks = networks.split()
2016-02-22 17:19:15 INFO config-changed AttributeError: 'Config' object has no attribute 'split'

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1171 ceph-next for james-page mp286819
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1171/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1007 ceph-next for james-page mp286819
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1007/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #451 ceph-next for james-page mp286819
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15172264/
Build: http://10.245.162.36:8080/job/charm_amulet_test/451/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #464 ceph-next for james-page mp286819
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15175208/
Build: http://10.245.162.36:8080/job/charm_amulet_test/464/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

There appears to be an actual failure in the proposal.

Unrelated to that: You'll need to rebase to refresh amulet tests.

Unmerged revisions

139. By James Page

Tweak comment

138. By James Page

Final tweak

137. By James Page

Tidy lint

136. By James Page

Tweak, restore caching to get_public_addr

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches