Merge lp://staging/~james-page/charms/precise/swift-proxy/review-feedback into lp://staging/~charmers/charms/precise/swift-proxy/trunk
Proposed by
James Page
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~james-page/charms/precise/swift-proxy/review-feedback |
| Merge into: | lp://staging/~charmers/charms/precise/swift-proxy/trunk |
| Diff against target: |
431 lines (+250/-59) 6 files modified
config.yaml (+13/-2) hooks/lib/openstack-common (+180/-0) hooks/swift-proxy-common (+30/-18) hooks/swift-proxy-relations (+24/-34) metadata.yaml (+2/-4) revision (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~james-page/charms/precise/swift-proxy/review-feedback |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
Review feedback
To post a comment you must log in.
Unmerged revisions
- 39. By James Page
-
Stop using /var/run/juju; it won't last past a reboot and then you get
hook failures.Make the interfaces actually make sense.
- 38. By James Page
-
Tweaks from review
- 37. By Adam Gandelman
-
Fix up package requirement detection, remove problematic chown.
- 36. By Adam Gandelman
-
set -e for hooks.
- 35. By Adam Gandelman
-
Rely on openstack-common: repo setup and determining packages.
Use the openstack-common functions to setup access to repositories
and determine what packages to install. - 34. By Adam Gandelman
-
Checkin openstack-common library.
- 33. By Adam Gandelman
-
Drop Canonical-specific workarounds (apt.conf flushing, swift-plugin-s3 deb)
- 32. By Adam Gandelman
-
FORMULA_DIR -> CHARM_DIR.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
