Juju Charms Collection
mysql package

Merge lp://staging/~james-page/charms/precise/mysql/remove-socket-fqdn into lp://staging/charms/mysql

  1. Precise Pangolin (12.04)
  2. remove-socket-fqdn
  3. Merge into trunk
Proposed by James Page
Status: Merged
Merged at revision: 100
Proposed branch: lp://staging/~james-page/charms/precise/mysql/remove-socket-fqdn
Merge into: lp://staging/charms/mysql
Diff against target: 19 lines (+2/-2)
2 files modified
hooks/shared_db_relations.py (+1/-1)
revision (+1/-1)
To merge this branch: bzr merge lp://staging/~james-page/charms/precise/mysql/remove-socket-fqdn
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+167723@code.staging.launchpad.net

Description of the change

Remove use of socket.fqdn from shared-db hooks

This assumes that DNS resolution is going to be working and infact should
be using unit-get private-address.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Thanks for this fix up. LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: