Merge lp://staging/~james-page/charms/precise/keystone/fix-requested-roles into lp://staging/~charmers/charms/precise/keystone/trunk

Proposed by James Page
Status: Merged
Approved by: Adam Gandelman
Approved revision: 54
Merged at revision: 45
Proposed branch: lp://staging/~james-page/charms/precise/keystone/fix-requested-roles
Merge into: lp://staging/~charmers/charms/precise/keystone/trunk
Diff against target: 72 lines (+29/-16)
1 file modified
hooks/keystone_hooks.py (+29/-16)
To merge this branch: bzr merge lp://staging/~james-page/charms/precise/keystone/fix-requested-roles
Reviewer Review Type Date Requested Status
Adam Gandelman (community) Approve
Review via email: mp+183580@code.staging.launchpad.net

Description of the change

Fixup requested_roles handling so that remote services not registering
endpoints can also request that new roles be created.

This fixes a problem in openstack deployments where swift is not being
used - the openstack-dashboard requests 'Member' but it was not actually
being created.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Note that the grant_role is automatically called by created role when the service username and tenant are passed.

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

LGTM, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: