Merge lp://staging/~james-page/charm-helpers/pikeandqueens into lp://staging/charm-helpers

Proposed by James Page
Status: Merged
Merged at revision: 740
Proposed branch: lp://staging/~james-page/charm-helpers/pikeandqueens
Merge into: lp://staging/charm-helpers
Diff against target: 166 lines (+43/-1)
3 files modified
charmhelpers/contrib/openstack/amulet/deployment.py (+5/-1)
charmhelpers/contrib/openstack/utils.py (+37/-0)
charmhelpers/core/host_factory/ubuntu.py (+1/-0)
To merge this branch: bzr merge lp://staging/~james-page/charm-helpers/pikeandqueens
Reviewer Review Type Date Requested Status
Alex Kavanagh Approve
James Page Needs Resubmitting
Review via email: mp+323789@code.staging.launchpad.net

Description of the change

Add support for pike and queens

To post a comment you must log in.
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

I think that the following also needs updating as part of the same commit:

- charmhelpers/core/host_factory/ubuntu.py -- L#20 probably needs 'artful' adding.
- charmhelpers/contrib/openstack/amulet/deployment.py -- around L#276 in the methods _get_openstack_release() and _get_openstack_release_string()

This functions also relate to OpenStack and Ubuntu releases.

review: Needs Fixing
741. By James Page

Misc other updates for artful

Revision history for this message
James Page (james-page) :
review: Needs Resubmitting
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches