Merge lp://staging/~james-page/charm-helpers/percona-tuning-level into lp://staging/charm-helpers

Proposed by James Page
Status: Merged
Merged at revision: 702
Proposed branch: lp://staging/~james-page/charm-helpers/percona-tuning-level
Merge into: lp://staging/charm-helpers
Diff against target: 147 lines (+121/-1)
2 files modified
charmhelpers/contrib/database/mysql.py (+27/-1)
tests/contrib/database/test_mysql.py (+94/-0)
To merge this branch: bzr merge lp://staging/~james-page/charm-helpers/percona-tuning-level
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+318755@code.staging.launchpad.net

Description of the change

Add parsing of tuning-level configuration option if detected.

To post a comment you must log in.
702. By James Page

Add other innodb config options and associated unit tests

Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

I see there are passing tests using this branch here: https://review.openstack.org/#/c/440333

and a big +1 to having tests with the branch. Thanks for the contribution

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches