Charm Helpers

Merge lp://staging/~james-page/charm-helpers/misc-percona-changes into lp://staging/charm-helpers

  1. misc-percona-changes
  2. Merge into devel
Proposed by James Page
Status: Merged
Merged at revision: 697
Proposed branch: lp://staging/~james-page/charm-helpers/misc-percona-changes
Merge into: lp://staging/charm-helpers
Diff against target: 134 lines (+38/-14)
3 files modified
charmhelpers/contrib/database/mysql.py (+9/-2)
test_requirements.txt (+1/-0)
tests/contrib/database/test_mysql.py (+28/-12)
To merge this branch: bzr merge lp://staging/~james-page/charm-helpers/misc-percona-changes
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Jorge Niedbalski (community) Approve
Review via email: mp+318253@code.staging.launchpad.net

Description of the change

Update default unset memory configuration behaviour and fixup unit tests.

To post a comment you must log in.
lp://staging/~james-page/charm-helpers/misc-percona-changes updated
698. By James Page

Amend NOTE

Revision history for this message
James Page (james-page) wrote :

This review also fixes up the mysql tests to work under py2 and py3

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

James,

Thanks for this addition. I agree with your rationale on this change.

Regarding tests, all the unit tests are passing OK.

LGTM

review: Approve
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Also good with this, many thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches