Merge lp://staging/~jameinel/loggerhead/tag_cache into lp://staging/loggerhead
Proposed by
John A Meinel
| Status: | Merged |
|---|---|
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~jameinel/loggerhead/tag_cache |
| Merge into: | lp://staging/loggerhead |
| Diff against target: |
27 lines (+5/-3) 1 file modified
loggerhead/history.py (+5/-3) |
| To merge this branch: | bzr merge lp://staging/~jameinel/loggerhead/tag_cache |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Hudson-Doyle | Approve | ||
|
Review via email:
|
|||
Description of the change
Another performance tweak. With the other patches I just proposed, this changes:
emacs/
The issue is that calling Branch.
It depends how many tags a branch has, but in the case of emacs, there are ~1,100 tags. And this was getting called for every revision being displayed in 'changes'. So 20 revs *1.1k tags getting deserialized.
It still happens 1 time per HTTP request, but at least it isn't 20 times.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Seems like a simple clear win to me.