Merge lp://staging/~jameinel/juju-core/hpcloud-1229480 into lp://staging/juju-core/1.14
Proposed by
John A Meinel
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1751 |
Proposed branch: | lp://staging/~jameinel/juju-core/hpcloud-1229480 |
Merge into: | lp://staging/juju-core/1.14 |
Diff against target: |
15 lines (+2/-2) 1 file modified
provider/openstack/provider.go (+2/-2) |
To merge this branch: | bzr merge lp://staging/~jameinel/juju-core/hpcloud-1229480 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+187485@code.staging.launchpad.net |
Commit message
fix boilerplate for hpcloud
We were saying AWS_ACCESS_KEY which we don't support and
AWS_SECRET_KEY which we do support, but probably isn't what we would
actually prefer to use for Openstack env variables
Description of the change
fix boilerplate for hpcloud
We were saying AWS_ACCESS_KEY which we don't support and
AWS_SECRET_KEY which we do support, but probably isn't what we would
actually prefer to use for Openstack env variables
To post a comment you must log in.
Reviewers: mp+187485_ code.launchpad. net,
Message:
Please take a look.
Description:
fix boilerplate for hpcloud
We were saying AWS_ACCESS_KEY which we don't support and
AWS_SECRET_KEY which we do support, but probably isn't what we would
actually prefer to use for Openstack env variables
https:/ /code.launchpad .net/~jameinel/ juju-core/ hpcloud- 1229480/ +merge/ 187485
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13902043/
Affected files (+4, -2 lines): openstack/ provider. go
A [revision details]
M provider/
Index: [revision details] 20130917234003- 54re4ia2qmlq7xt 3
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: provider/ openstack/ provider. go openstack/ provider. go' openstack/ provider. go 2013-09-11 06:27:05 +0000 openstack/ provider. go 2013-09-25 10:40:26 +0000 ACCESS_ KEY, but can be
=== modified file 'provider/
--- provider/
+++ provider/
@@ -114,9 +114,9 @@
# region: <your region>
# The following are used for keypair authentication
# auth-mode: keypair
- # Usually set via the env variable AWS_ACCESS_KEY_ID, but can be
specified here
+ # Usually set via the env variable OS_ACCESS_KEY, but can be specified
here
# access-key: <secret>
- # Usually set via the env variable AWS_SECRET_
specified here
+ # Usually set via the env variable OS_SECRET_KEY, but can be specified
here
# secret-key: <secret>
`[1:]