Code review comment for lp://staging/~jameinel/bzr/2.4-cheaper-iter-entries-by-dir

Revision history for this message
Vincent Ladeuil (vila) wrote :

29 + if from_dir is None and specific_file_ids is None:
30 + # They are iterating from the root, and have not specified any
31 + # specific entries to look at. All current callers fully consume the
32 + # iterator, so we can safely assume we are accessing all entries
33 + self._preload_cache()
34 if from_dir is None:
35 if self.root is None:
36 return

You're pre-loading the cache even when from_dir and self.root are None, is there nothing to preload in this case or does it mean the shortcut is now ineffective and what are the consequences then ?

review: Needs Information

« Back to merge proposal