Code review comment for lp://staging/~jameinel/bzr/2.4-cheaper-iter-entries-by-dir

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/18/2011 5:36 PM, Jelmer Vernooij wrote:
> Somebody recently mentioned to me that we don't allow the use of "assert"... :-)

You're absolutely right, I meant to pull those out after I had it working.

I updated it to raise ValueError on any of the inconsistencies. None of
them should ever trigger, and I wonder if we really want to check them.
But since I did it, I'm ok leaving it in. It probably makes the code a
little bit harder to follow, though.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2EZ50ACgkQJdeBCYSNAAOSuQCfQw0i9e8P/t+z05Cnj7GpxO2I
MywAnjaoZWUX50HQvui+OyYfGXoOA9R1
=nAEZ
-----END PGP SIGNATURE-----

« Back to merge proposal