Ubuntu Start Page

Merge lp://staging/~jakobunt/ubuntu-start-page/fix-lang into lp://staging/ubuntu-start-page

  1. fix-lang
  2. Merge into trunk
Proposed by Jakob Unterwurzacher
Status: Merged
Approved by: Martin Albisetti
Approved revision: 101
Merged at revision: 100
Proposed branch: lp://staging/~jakobunt/ubuntu-start-page/fix-lang
Merge into: lp://staging/ubuntu-start-page
Diff against target: 411 lines (+38/-0)
34 files modified
translation-scripts/translation-functions.sh (+5/-0)
www/10.04/index.html.ar (+1/-0)
www/10.04/index.html.ast (+1/-0)
www/10.04/index.html.bg (+1/-0)
www/10.04/index.html.bn (+1/-0)
www/10.04/index.html.ca (+1/-0)
www/10.04/index.html.crh (+1/-0)
www/10.04/index.html.da (+1/-0)
www/10.04/index.html.de (+1/-0)
www/10.04/index.html.el (+1/-0)
www/10.04/index.html.en (+1/-0)
www/10.04/index.html.es (+1/-0)
www/10.04/index.html.fi (+1/-0)
www/10.04/index.html.fr (+1/-0)
www/10.04/index.html.gl (+1/-0)
www/10.04/index.html.he (+1/-0)
www/10.04/index.html.hr (+1/-0)
www/10.04/index.html.hu (+1/-0)
www/10.04/index.html.id (+1/-0)
www/10.04/index.html.is (+1/-0)
www/10.04/index.html.it (+1/-0)
www/10.04/index.html.ja (+1/-0)
www/10.04/index.html.ko (+1/-0)
www/10.04/index.html.lv (+1/-0)
www/10.04/index.html.nds (+1/-0)
www/10.04/index.html.nl (+1/-0)
www/10.04/index.html.pt-br (+1/-0)
www/10.04/index.html.ro (+1/-0)
www/10.04/index.html.ru (+1/-0)
www/10.04/index.html.sk (+1/-0)
www/10.04/index.html.sv (+1/-0)
www/10.04/index.html.th (+1/-0)
www/10.04/index.html.vi (+1/-0)
www/10.04/index.html.zh-cn (+1/-0)
To merge this branch: bzr merge lp://staging/~jakobunt/ubuntu-start-page/fix-lang
Reviewer Review Type Date Requested Status
Martin Albisetti (community) Approve
Roman Yepishev (community) Approve
Review via email: mp+24307@code.staging.launchpad.net

Description of the change

r100:
Correct the language of the google results by inserting a hidden hl field
<input type="hidden" name="hl" value="$lang" />
in all the index.html.$lang

r101:
Add logic to translation-functions.sh to translate hidden hl field
                  <input type="hidden" name="hl" value="en" />
automatically.

Tested to produce the exact same output files as we have from r100.

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

Verified that Google language is indeed changed by modifying the content of the <form> in firebug by adding respective items for Russian (ru) and German (de).

review: Approve
lp://staging/~jakobunt/ubuntu-start-page/fix-lang updated
101. By jakob <jakob@laj>

Add logic to translation-functions.sh to translate hidden hl field
                <input type="hidden" name="hl" value="en" />
automatically.

Revision history for this message
Martin Albisetti (beuno) wrote :

This looks good. I'll look into deploying it after the Lucid launch. Thanks for working on it.

review: Approve
Revision history for this message
Paul Sladen (sladen) wrote :

Any chance we could have this merged *before* the release tomorrow. (It is asynchronous with the CD image, so not blocking anything).

First impressions of workingness really count, as this whole exercise is somewhat defeated if user fires up their browser, is ultimately then disappointed and then chooses to override their start page with something else.

Revision history for this message
Martin Albisetti (beuno) wrote :

Very very very unlikely, the sysadmins are all tied up due to the release, and it's going to be impossible to grab their attention.
Not to say that I won't try... :)

Revision history for this message
Paul Sladen (sladen) wrote :

Duuuudes. Please apply the Google CSE results language patch to make non-English Users' efforts meaningful.

Pretty please with chocolate fountains on top.

And cherries.

Revision history for this message
Martin Albisetti (beuno) wrote :

Sorry Paul, I will get to it today and file the RT for re-deployment.

Revision history for this message
Martin Albisetti (beuno) wrote :

Merged into trunk, RT filed for this to be rolled out, I don't have an ETA for that yet.

Revision history for this message
Paul Sladen (sladen) wrote :

Would be perfect timing to deploy this, based on this week's Brainstorm top 5:

 * Non-internationalized search results via the Ubuntu Start Page -
   http://brainstorm.ubuntu.com/idea/24888/

Then somebody can take the credit for swiftly reacting.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches