Juju Charms Collection
mysql package

Merge lp://staging/~jacekn/charms/trusty/mysql/mysql-storage-bugfix into lp://staging/charms/trusty/mysql

  1. Trusty Tahr (14.04)
  2. mysql-storage-bugfix
  3. Merge into trunk
Proposed by Jacek Nykis
Status: Merged
Merged at revision: 138
Proposed branch: lp://staging/~jacekn/charms/trusty/mysql/mysql-storage-bugfix
Merge into: lp://staging/charms/trusty/mysql
Diff against target: 21 lines (+11/-0)
1 file modified
hooks/common.py (+11/-0)
To merge this branch: bzr merge lp://staging/~jacekn/charms/trusty/mysql/mysql-storage-bugfix
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Nick Moffitt (community) Approve
Review Queue (community) automated testing Approve
Review via email: mp+249203@code.staging.launchpad.net

Description of the change

Fix a bug where the charm could (partially) overwrite data on persistent storage.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1667 mysql for jacekn mp249203
    UNIT FAIL: unit-test missing

UNIT Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full unit test output: http://paste.ubuntu.com/10159635/
Build: http://10.245.162.77:8080/job/charm_unit_test/1667/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1836 mysql for jacekn mp249203
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1836/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1855 mysql for jacekn mp249203
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10159641/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1855/

Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://reports.vapour.ws/charm-tests/charm-bundle-test-11005-results

review: Approve (automated testing)
Revision history for this message
Nick Moffitt (nick-moffitt) :
review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1833 mysql for jacekn mp249203
    UNIT FAIL: unit-test missing

UNIT Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full unit test output: http://paste.ubuntu.com/10267608/
Build: http://10.245.162.77:8080/job/charm_unit_test/1833/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2043 mysql for jacekn mp249203
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2043/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1981 mysql for jacekn mp249203
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10267618/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1981/

Revision history for this message
Chris Glass (tribaal) wrote :

Good catch! That is a potentially severe problem (data loss).

I guess this should be streamlined when the juju storage story consolidates, but for now it seems to me like an appropriate course of action to prompt the user (it's his data, after all).

+1 (merging)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: