Merge ~jacekn/charm-prometheus-alertmanager:fixes into ~prometheus-charmers/charm-prometheus-alertmanager:master
Proposed by
Jacek Nykis
| Status: | Merged |
|---|---|
| Merged at revision: | ca499e551821bd682e35bdf336541724b3e08d09 |
| Proposed branch: | ~jacekn/charm-prometheus-alertmanager:fixes |
| Merge into: | ~prometheus-charmers/charm-prometheus-alertmanager:master |
| Diff against target: |
219 lines (+12/-124) 2 files modified
config.yaml (+0/-26) templates/alertmanager.yml.j2 (+12/-98) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| JuanJo Ciarlante (community) | lgtm | Approve | |
| Stuart Bishop (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Remove redundant enable_* config options. Rework receivers config so that alerts go to all of them not just first one
To post a comment you must log in.
Revision history for this message
| JuanJo Ciarlante (jjo) | # |
review:
Approve
(lgtm)
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me. I'm not familiar with alertmanager config, but the changes appear sensible and are understandable.