Merge ~jacekn/charm-prometheus-alertmanager:master into ~prometheus-charmers/charm-prometheus-alertmanager:master

Proposed by Jacek Nykis
Status: Merged
Merged at revision: e0b21ba2d7b7c26de9dcf4b918967bfd66978d75
Proposed branch: ~jacekn/charm-prometheus-alertmanager:master
Merge into: ~prometheus-charmers/charm-prometheus-alertmanager:master
Diff against target: 210 lines (+55/-68)
6 files modified
config.yaml (+6/-22)
dev/null (+0/-23)
layer.yaml (+1/-1)
metadata.yaml (+1/-1)
reactive/alertmanager.py (+24/-21)
templates/daemon_arguments.j2 (+23/-0)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+316151@code.staging.launchpad.net

Description of the change

Switch to xenial and snap as install method

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

This looks fine. Some thoughts on the snap layer inline, and there is a work around you should not need.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches