Merge lp://staging/~izidor/gtg/default_preferences_plugins into lp://staging/~gtg/gtg/old-trunk
Proposed by
Izidor Matušov
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1277 | ||||
| Proposed branch: | lp://staging/~izidor/gtg/default_preferences_plugins | ||||
| Merge into: | lp://staging/~gtg/gtg/old-trunk | ||||
| Diff against target: |
194 lines (+39/-56) 8 files modified
CHANGELOG (+1/-0) GTG/core/plugins/api.py (+11/-4) GTG/plugins/export/export.py (+3/-6) GTG/plugins/hamster/hamster.py (+3/-7) GTG/plugins/notification_area/notification_area.py (+3/-7) GTG/plugins/task_reaper/reaper.py (+3/-6) GTG/plugins/untouched_tasks/untouchedTasks.py (+3/-6) GTG/plugins/urgency_color/urgency_color.py (+12/-20) |
||||
| To merge this branch: | bzr merge lp://staging/~izidor/gtg/default_preferences_plugins | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nimit Shah | Approve | ||
| Gtg developers | Pending | ||
|
Review via email:
|
|||
Description of the change
Plugin API now takes care about default values of preferences, thus simplify lives of plugin creators (by removing couple lines to write :)
To post a comment you must log in.
Revision history for this message
| Nimit Shah (nimit-svnit) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Izidor,
The code looks proper to me.
Just one small thing: Would "config" be a more intuitive variable name then "result"? Not an important question, you can always ignore it :)