Prometheus Openstack Exporter Charm

Merge ~ivoks/charm-prometheus-openstack-exporter:credentials into ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master

  1. Git
  2. lp:~ivoks/charm-prometheus-openstack-exporter
  3. credentials
  4. Merge into master
Proposed by Ante Karamatić
Status: Rejected
Rejected by: Drew Freiberger
Proposed branch: ~ivoks/charm-prometheus-openstack-exporter:credentials
Merge into: ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master
Diff against target: 19 lines (+2/-2)
1 file modified
reactive/openstack_exporter.py (+2/-2)
Reviewer Review Type Date Requested Status
Drew Freiberger (community) Disapprove
Review via email: mp+349041@code.staging.launchpad.net

Commit message

Keystone might not be ready by the time relation with prometheus-openstack-exporter kicks in. This ensures that prometheus-openstack-exporter charm won't fail if creds from keystone are not yet available.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Drew Freiberger (afreiberger) wrote :

This was covered with:
        # lp#1785864 - Workaround Keystone relation not yet ready.
        if creds is None:
            hookenv.log('get_credentials: config os-credentials not set and '
                        'identity-credentials relation not yet ready')
            return None

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches