Merge lp://staging/~ivaldi/midori/tabby-about-sessions into lp://staging/midori
Proposed by
André Stösel
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~ivaldi/midori/tabby-about-sessions |
| Merge into: | lp://staging/midori |
| Diff against target: |
172 lines (+91/-2) 6 files modified
midori/marshal.list (+1/-0) midori/midori-resource.vala (+17/-0) midori/midori-view.c (+53/-2) midori/midori.vapi (+1/-0) midori/sokoke.c (+13/-0) midori/sokoke.h (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~ivaldi/midori/tabby-about-sessions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cris Dywan | Needs Information | ||
|
Review via email:
|
|||
Commit message
add about:sessions
Description of the change
Correlates with lp:~ivaldi/midori/outsource-about-pages
To post a comment you must log in.
Revision history for this message
| André Stösel (ivaldi) wrote | # |
Unmerged revisions
- 6435. By André Stösel
-
fix vapi
- 6434. By André Stösel
-
emit RESOURCE_REQUEST
- 6433. By André Stösel
-
add Midori.Resource base class
- 6432. By André Stösel
-
add resource_request signal to vapi
- 6431. By André Stösel
-
new signal view:resource-
request - 6430. By André Stösel
-
new marshal object:string
- 6429. By André Stösel
-
new accumulator for objects
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Did you consider making contents and mime_type properties rather than functions? That way they could be set and kept around, and used without subclassing.
Will resource-request replace about-content?
Will res:// and stock:// be implemented with resource-request? Then they wouldn't need their own #if for wk2 anymore.
And if I may suggest, this branch looks more like "refactor about: pages with new API" than about:sessions.