Merge lp://staging/~isantop/system76-driver/development into lp://staging/system76-driver/3.0

Proposed by Ian Santopietro
Status: Merged
Approved by: Carl Richell
Approved revision: 59
Merged at revision: 49
Proposed branch: lp://staging/~isantop/system76-driver/development
Merge into: lp://staging/system76-driver/3.0
Diff against target: 6060 lines (+3910/-1286)
15 files modified
AUTHORS (+6/-0)
System76Drivergtk3.py (+54/-17)
acpi.py (+236/-160)
driverscontrol.py (+341/-334)
driversdescribe.py (+2149/-0)
fprint.py (+96/-72)
hardy_led.py (+11/-2)
hotkey.py (+67/-47)
misc.py (+261/-179)
ricoh_cr.py (+12/-4)
sound.py (+420/-354)
system76Driver-gtk3.glade (+139/-27)
usplash.py (+61/-54)
usr/bin/system76-driver.py (+2/-0)
uvc.py (+55/-36)
To merge this branch: bzr merge lp://staging/~isantop/system76-driver/development
Reviewer Review Type Date Requested Status
Carl Richell thorough Approve
Review via email: mp+108177@code.staging.launchpad.net

Commit message

Added in "View Details" button to list what drivers are going to be installed, and related UI tweaks.

Description of the change

This branch implements a "view details" button in the GTK3 interface. When clicked, this button expands a small text field at the bottom of the window with a list of all drivers to be installed on a particular machine. Additionally, it reworks the previous notification area slightly due the reduced horizontal space (with some original space now taken up by the Details button).

It also addresses a number of issues with the current 2.9 startup script to make it less hardcoded and more portable.

After running through testing, this code appears to be stable and feature-complete, and should be merged into the main 2.9 codebase.

To post a comment you must log in.
Revision history for this message
Carl Richell (carlrichell) :
review: Approve (thorough)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches