OpenERP Management System

Merge lp://staging/~invitu/openerp-mgmtsystem/7-0_fix_security into lp://staging/openerp-mgmtsystem

7-0_fix_security
Merge into 7.0

Proposed by invitu on 2014-02-25

Status:	Merged
Approved by:	Guewen Baconnier @ Camptocamp on 2014-02-28
Approved revision:	93
Merged at revision:	94
Proposed branch:	lp://staging/~invitu/openerp-mgmtsystem/7-0_fix_security
Merge into:	lp://staging/openerp-mgmtsystem
Diff against target:	30 lines (+22/-2) 1 file modified mgmtsystem_hazard/security/ir.model.access.csv (+22/-2)
To merge this branch:	bzr merge lp://staging/~invitu/openerp-mgmtsystem/7-0_fix_security
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Reis	code review no test		Approve on 2014-02-26
Pedro Manuel Baeza	code review	2014-02-25	Approve on 2014-02-25
Maxime Chambreuil (http://www.savoirfairelinux.com)			Approve on 2014-02-25
invitu (community)			Needs Resubmitting on 2014-02-25
Review via email: mp+208239@code.staging.launchpad.net

Description of the change

fix security for objects

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-02-25:

Hi, I think you have forgotten some access rules:

- risk_computation_manager
- hazard_probability_manager
- hazard_severity_manager
- hazard_usage_manager
- hazard_risk_type_user
- hazard_hazard_user
- hazard_hazard_test_user
- hazard_control_measure_user
- hazard_residual_risk_user
- hazard_type_manager

Thanks.

Regards-

review: Needs Fixing (code review)

Revision history for this message

invitu (invitu) wrote on 2014-02-25:

thanks for your comment
missing rules have been added
regards

review: Needs Resubmitting

Revision history for this message

Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) on 2014-02-25:

review: Approve

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-02-25:

Thanks for the changes.

Regards.

review: Approve (code review)

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-02-26:

Shouldn't "base.group_user" in L5,L6 be "mgmtsystem.group_mgmtsystem_user" instead?

BTW, there's no need to "resubmit proposal". Just pushing the additional changes is enough, and the additional revision will be displayed in the discussion history.

review: Needs Information

lp://staging/~invitu/openerp-mgmtsystem/7-0_fix_security updated on 2014-02-26