Merge ~intrigeri/apparmor-profiles/+git/apparmor-profiles:stricter-totem into ~apparmor-dev/apparmor-profiles/+git/apparmor-profiles-old:master

Proposed by intrigeri
Status: Merged
Merged at revision: bfc0bffc1ca87bd8cae4204cd3bdb62f20dd82ad
Proposed branch: ~intrigeri/apparmor-profiles/+git/apparmor-profiles:stricter-totem
Merge into: ~apparmor-dev/apparmor-profiles/+git/apparmor-profiles-old:master
Diff against target: 209 lines (+63/-18)
6 files modified
ubuntu/17.04/abstractions/totem (+16/-3)
ubuntu/17.04/usr.bin.totem (+9/-2)
ubuntu/17.04/usr.bin.totem-previewers (+6/-4)
ubuntu/17.10/abstractions/totem (+17/-3)
ubuntu/17.10/usr.bin.totem (+9/-2)
ubuntu/17.10/usr.bin.totem-previewers (+6/-4)
Reviewer Review Type Date Requested Status
Steve Beattie Approve
Review via email: mp+310120@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
intrigeri (intrigeri) wrote :
Revision history for this message
Seth Arnold (seth-arnold) wrote :

What motivated the change from ** to [a-zA-Z0-9]? This will prevent access to files in directories Видео/ or ビデオ/.

Thanks

Revision history for this message
intrigeri (intrigeri) wrote :

Hi!

Seth Arnold:
> What motivated the change from ** to [a-zA-Z0-9]?

Noticing that Totem had access e.g. to my OTR and GnuPG private keys,
which seems to void most of the purpose (for my use case at least) of
confining Totem in the first place. Basically, in my tests, the "**"
rule cancels the effect of private-files-strict.

> This will prevent access to files in directories Видео/ or ビデオ/.

Oops, good catch. Thank you! I'll resubmit something nicer (and
simpler), i.e. granting access to any file in $HOME, as long as the
name of the top-level sub-directory does not start with '.'.

Revision history for this message
intrigeri (intrigeri) wrote :

Updated!

Revision history for this message
intrigeri (intrigeri) wrote :

Merged current master, copied changes to 17.10. I've now been using these changes since more than 7 months on my main system, and didn't notice any issue. The concern raised by Seth during his first review pass was addressed a while ago :) Time for another review?

Revision history for this message
intrigeri (intrigeri) wrote :

Added one more Mesa-related rule to fix a problem reported on Debian (where I've already applied this MR).

Revision history for this message
intrigeri (intrigeri) wrote :

All concerns raised in the initial review have been addressed 10 months ago. Again, this changeset has been applied in Debian and Tails for a while, and nobody complained :)

Is there anything I can do to help speed this up?

Revision history for this message
Steve Beattie (sbeattie) wrote :

Thanks for your patience! Looks good, merged.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches