Merge lp://staging/~ingenieria-adhoc/account-financial-tools/currency_update into lp://staging/~account-core-editors/account-financial-tools/7.0

Proposed by Juan José Scarafía (ADHOC)
Status: Superseded
Proposed branch: lp://staging/~ingenieria-adhoc/account-financial-tools/currency_update
Merge into: lp://staging/~account-core-editors/account-financial-tools/7.0
Diff against target: 33 lines (+13/-3)
1 file modified
currency_rate_update/currency_rate_update.py (+13/-3)
To merge this branch: bzr merge lp://staging/~ingenieria-adhoc/account-financial-tools/currency_update
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Approve
Review via email: mp+203755@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-02-04.

Description of the change

We make base currency based on currency marked as base and not related to company currency because sometimes your company currency is not the same you use as base currency. We think this way is more appropiate

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Good improvement, thanks, but instead of print statements, could you please raise orm.except_orm exception?

Regards.

review: Approve
149. By Juan José Scarafía (ADHOC)

FIX replace print for orm.except_orm

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches