Merge lp://staging/~ilidrissi.amine/update-manager/group-of-patches into lp://staging/update-manager
Proposed by
Mohamed Amine Ilidrissi
| Status: | Merged |
|---|---|
| Merged at revision: | 1890 |
| Proposed branch: | lp://staging/~ilidrissi.amine/update-manager/group-of-patches |
| Merge into: | lp://staging/update-manager |
| Diff against target: |
41 lines (+7/-2) 3 files modified
UpdateManager/Core/MyCache.py (+2/-0) UpdateManager/UpdateManager.py (+3/-2) debian/changelog (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~ilidrissi.amine/update-manager/group-of-patches |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch includes 2 patches from Nicolò Chieffo. Please see the related bugs for more info.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| Mohamed Amine Ilidrissi (ilidrissi.amine) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the branch. Unfortunately the change to look for changelogs inside launchpad is not suitable. The reason is that launchpad.net generates the pages dynamically out of a database. Hitting them from potentially hundrets of thousands of users is dangerous. But the good news is that the launchpad soyuz team is working on providing the changelogs in the PPA pool/ directory. This way its a static file served by apache and we can use that performance risks for launchpad.
The other fix looks very good and I'm happy to take it.