Merge lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs into lp://staging/software-center
Proposed by
Michael Vogt
Status: | Merged | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1251 | ||||||||||||||||
Proposed branch: | lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs | ||||||||||||||||
Merge into: | lp://staging/software-center | ||||||||||||||||
Diff against target: |
151 lines (+39/-7) 6 files modified
debian/changelog (+8/-0) debian/control (+2/-1) softwarecenter/apt/apthistory.py (+13/-0) softwarecenter/view/appdetailsview_gtk.py (+12/-2) softwarecenter/view/availablepane.py (+3/-3) softwarecenter/view/historypane.py (+1/-1) |
||||||||||||||||
To merge this branch: | bzr merge lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs | ||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email:
|
To post a comment you must log in.
Thanks for this branch.
I noticed that there are two lines like this:
if self.adjustment _value is not None \ _value <= self.get_ vadjustment( ).lower \ _value <= self.get_ vadjustment( ).upper:
self. get_vadjustment ().set_ value(self. adjustment_ value)
and self.adjustment
and self.adjustment
but once its (notice that the >= and <= in the second but "<= and <=" in the
first. Is this a accident? I smells like this should be moved into a single
helper function.
if self.adjustment _value is not None \ _value >= self.get_ vadjustment( ).lower \ _value <= self.get_ vadjustment( ).upper:
self. get_vadjustment ().set_ value(self. adjustment_ value)
and self.adjustment
and self.adjustment
The second part of the branch with the translation string clarifications is
great, but not quite suitable for 3.0 because we are in string freeze and this
would fuzzy existing translations. I will move it to trunk instead.