Merge lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs into lp://staging/software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 1251
Proposed branch: lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs
Merge into: lp://staging/software-center
Diff against target: 151 lines (+39/-7)
6 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
softwarecenter/apt/apthistory.py (+13/-0)
softwarecenter/view/appdetailsview_gtk.py (+12/-2)
softwarecenter/view/availablepane.py (+3/-3)
softwarecenter/view/historypane.py (+1/-1)
To merge this branch: bzr merge lp://staging/~ilidrissi.amine/software-center/fixing-random-bugs
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+34656@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch.

I noticed that there are two lines like this:

        if self.adjustment_value is not None \
        and self.adjustment_value <= self.get_vadjustment().lower \
        and self.adjustment_value <= self.get_vadjustment().upper:
            self.get_vadjustment().set_value(self.adjustment_value)

but once its (notice that the >= and <= in the second but "<= and <=" in the
first. Is this a accident? I smells like this should be moved into a single
helper function.

        if self.adjustment_value is not None \
        and self.adjustment_value >= self.get_vadjustment().lower \
        and self.adjustment_value <= self.get_vadjustment().upper:
            self.get_vadjustment().set_value(self.adjustment_value)

The second part of the branch with the translation string clarifications is
great, but not quite suitable for 3.0 because we are in string freeze and this
would fuzzy existing translations. I will move it to trunk instead.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches