Merge lp://staging/~ilasc/loggerhead/fix-download-links into lp://staging/loggerhead
Proposed by
Ioana Lasc
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ioana Lasc | ||||
| Approved revision: | 536 | ||||
| Merge reported by: | Otto Co-Pilot | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~ilasc/loggerhead/fix-download-links | ||||
| Merge into: | lp://staging/loggerhead | ||||
| Diff against target: |
101 lines (+45/-5) 5 files modified
loggerhead/controllers/download_ui.py (+1/-1) loggerhead/templates/inventory.pt (+2/-2) loggerhead/tests/fixtures.py (+2/-2) loggerhead/tests/test_controllers.py (+9/-0) loggerhead/tests/test_inventory_ui.py (+31/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~ilasc/loggerhead/fix-download-links | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
| Jelmer Vernooij | Approve | ||
|
Review via email:
|
|||
Commit message
Fix file download links in inventory UI
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) | # |
review:
Approve
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think this is reasonable - it matches the URL structure used by some other similar controllers, e.g. view.