Merge lp://staging/~ignacio-nin/galera/galera-2.x into lp://staging/galera/2.x
Proposed by
Ignacio Nin
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Alex Yurchenko | ||||
| Proposed branch: | lp://staging/~ignacio-nin/galera/galera-2.x | ||||
| Merge into: | lp://staging/galera/2.x | ||||
| Diff against target: |
78 lines (+26/-10) 2 files modified
SConstruct (+9/-5) garb/SConscript (+17/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~ignacio-nin/galera/galera-2.x | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alex Yurchenko | Abstain | ||
|
Review via email:
|
|||
Description of the change
To post a comment you must log in.
Unmerged revisions
- 128. By Ignacio Nin
-
Ability to specify the path to libboost_
program_ options. a Add a bpostatic parameter to the scons script, so the full path to the
location of libboost_program_ options. a can be specified. This is to
avoid having more hardcoded paths (/usr/lib, /usr/local/lib, etc.) in
garb/Sconscript. - 127. By Ignacio Nin
-
Avoid linkage against libboost_
program_ options Library libboost_
program_ options was being added to the global
environment, causing libgalera_smm.so to be unnecessarily linked against
it.This change clones the environment for garbd so libboost_
program_ options
is just linked against it.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Ignacio, sorry for taking so long. This is a good patch, but I'm afraid we need to clarify the copyright issues here - namely we need a copyright (not exclusive, but nevertheless) on that code. I'll double this in the mailing list.