Merge lp://staging/~hyuchia/noise/fix-1594598 into lp://staging/~elementary-apps/noise/trunk
Proposed by
Diego Islas Ocampo
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Danielle Foré | ||||
| Proposed branch: | lp://staging/~hyuchia/noise/fix-1594598 | ||||
| Merge into: | lp://staging/~elementary-apps/noise/trunk | ||||
| Diff against target: |
1122 lines (+342/-343) 14 files modified
core/Settings.vala (+3/-3) data/CMakeLists.txt (+7/-7) data/io.elementary.noise.appdata.xml.in (+38/-0) data/io.elementary.noise.desktop.in.in (+19/-0) data/org.pantheon.noise.appdata.xml.in (+0/-38) data/org.pantheon.noise.desktop.in.in (+0/-19) plugins/LastFM/noise-lastfm.application (+1/-1) plugins/MPRIS/MPRIS.vala (+74/-74) schemas/CMakeLists.txt (+1/-1) schemas/io.elementary.noise.gschema.xml (+186/-0) schemas/org.pantheon.noise.gschema.xml (+0/-186) src/LocalBackend/LocalLibrary.vala (+4/-5) src/Noise.vala (+3/-3) src/Objects/HistoryPlaylist.vala (+6/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~hyuchia/noise/fix-1594598 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Description of the change
Removed all references to org.pantheon and replaced them with the io.elementary scheme.
To post a comment you must log in.
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Unmerged revisions
- 2051. By Diego Islas Ocampo
-
Use right scheme for paths
- 2050. By Diego Islas Ocampo
-
Merge with latest trunk
- 2049. By Diego Islas Ocampo
-
Remove translation conflicts
- 2048. By Diego Islas Ocampo
-
Use the right reversed elementary Scheme
- 2047. By Diego Islas Ocampo
-
Remove unused variable
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey Diego, This branch has a lot of changes in it that aren't related to changing the app ID. Can you open a new PR on GitHub with only those changes? https:/